Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
The playground generator writes
@ionic/core@<version>into eachdemo.htmlfor the version you pick. For a major not yet on npm, such as 10 onmajor-10.0, jsDelivr returns 404 and the demo renders blank. Every v10 playground so far has been fixed by hand, 884 CDN references onmajor-10.0alone.What is the new behavior?
latestdist-tag from npm. If the picked major is newer,demo.htmlloads the latest published major and gets aTODO(FW-XXXX)comment above the CDN links.On
mainnothing changes, since 8 and 9 are both published. The fallback applies on major branches after the next main merge.Does this introduce a breaking change?
Other information
Verified by running the prompt function with mocked answers and rendering
demo.html: 8 and 9 load their own version with no TODO, 10 loads 9 with the TODO, and 10 offline loads 10 with a warning.